netdev - Re: [PATCH net v2] docs: netdev: document guidance on cleanup.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240830203109.GB4063074@kernel.org>
Date: Fri, 30 Aug 2024 21:31:09 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, Nikolay Aleksandrov <razor@...ckwall.org>,
	Andrew Lunn <andrew@...n.ch>, corbet@....net,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH net v2] docs: netdev: document guidance on cleanup.h

On Fri, Aug 30, 2024 at 10:14:42AM -0700, Jakub Kicinski wrote:
> Document what was discussed multiple times on list and various
> virtual / in-person conversations. guard() being okay in functions
> <= 20 LoC is a bit of my own invention. If the function is trivial
> it should be fine, but feel free to disagree :)
> 
> We'll obviously revisit this guidance as time passes and we and other
> subsystems get more experience.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: horms@...nel.org
> CC: corbet@....net
> CC: linux-doc@...r.kernel.org
> 
> v2:
>  - add sentence about revisiting later to commit msg
>  - fix spelling
> v1: https://lore.kernel.org/20240829152025.3203577-1-kuba@kernel.org

Thanks. I think this patch has enough tags, so I won't add another.
But, FTR, this version looks good to me.

...