netdev - Re: [PATCH net 13/13] can: kvaser_pciefd: Enable 64-bit DMA addressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240830-cheerful-dinosaur-of-relaxation-a9905c-mkl@pengutronix.de>
Date: Sat, 31 Aug 2024 00:03:44 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, linux-can@...r.kernel.org, 
	kernel@...gutronix.de, Martin Jocic <martin.jocic@...ser.com>
Subject: Re: [PATCH net 13/13] can: kvaser_pciefd: Enable 64-bit DMA
 addressing

On 30.08.2024 13:17:24, Jakub Kicinski wrote:
> On Thu, 29 Aug 2024 21:20:46 +0200 Marc Kleine-Budde wrote:
> > +	if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT))
> > +		dma_set_mask_and_coherent(&pcie->pci->dev, DMA_BIT_MASK(64));
> 
> This IS_ENABLED() is quite unusual. The driver just advertises its
> capability of using 64 addressing. If the platform doesn't support
> 64b DMA addressing and therefore dma_addr_t is narrower, everything
> will still work. I could be wrong, but that's how I understand it.

Ditch this PR.

I have sent out a new PR without this patch; however, it contains an
additional patch that has since arrived.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)