netdev - RE: [PATCH net-next 2/2] net: Remove setting of RX software timestamp from drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <LV8PR11MB870012278E21DDE4091D36759F972@LV8PR11MB8700.namprd11.prod.outlook.com>
Date: Fri, 30 Aug 2024 06:10:59 +0000
From: <Raju.Lakkaraju@...rochip.com>
To: <gal@...dia.com>, <davem@...emloft.net>, <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <jv@...sburgh.net>, <andy@...yhouse.net>,
	<mkl@...gutronix.de>, <mailhol.vincent@...adoo.fr>,
	<Shyam-sundar.S-k@....com>, <skalluru@...vell.com>, <manishc@...vell.com>,
	<michael.chan@...adcom.com>, <pavan.chebbi@...adcom.com>,
	<Nicolas.Ferre@...rochip.com>, <claudiu.beznea@...on.dev>,
	<sgoutham@...vell.com>, <bharat@...lsio.com>, <benve@...co.com>,
	<satishkh@...co.com>, <claudiu.manoil@....com>, <vladimir.oltean@....com>,
	<wei.fang@....com>, <shenwei.wang@....com>, <xiaoning.wang@....com>,
	<dmichail@...gible.com>, <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
	<shaojijie@...wei.com>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>, <marcin.s.wojtas@...il.com>,
	<linux@...linux.org.uk>, <gakula@...vell.com>, <sbhatta@...vell.com>,
	<hkelam@...vell.com>, <idosch@...dia.com>, <petrm@...dia.com>,
	<Bryan.Whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
	<Horatiu.Vultur@...rochip.com>, <Lars.Povlsen@...rochip.com>,
	<Steen.Hegelund@...rochip.com>, <Daniel.Machon@...rochip.com>,
	<alexandre.belloni@...tlin.com>, <shannon.nelson@....com>,
	<brett.creeley@....com>, <s.shtylyov@....ru>,
	<yoshihiro.shimoda.uh@...esas.com>, <niklas.soderlund@...natech.se>,
	<ecree.xilinx@...il.com>, <habetsm.xilinx@...il.com>,
	<alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>,
	<mcoquelin.stm32@...il.com>, <s-vadapalli@...com>, <rogerq@...nel.org>,
	<danishanwar@...com>, <linusw@...nel.org>, <kaloz@...nwrt.org>,
	<richardcochran@...il.com>, <willemdebruijn.kernel@...il.com>,
	<cjubran@...dia.com>, <rrameshbabu@...dia.com>
Subject: RE: [PATCH net-next 2/2] net: Remove setting of RX software timestamp
 from drivers

> [Some people who received this message don't often get email from
> gal@...dia.com. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
> 
> Reviewed-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
> Signed-off-by: Gal Pressman <gal@...dia.com>
> ---

> diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c
> b/drivers/net/ethernet/microchip/lan743x_ethtool.c
> index 3a63ec091413..0f1c0edec460 100644
> --- a/drivers/net/ethernet/microchip/lan743x_ethtool.c
> +++ b/drivers/net/ethernet/microchip/lan743x_ethtool.c
> @@ -1034,16 +1034,12 @@ static int lan743x_ethtool_get_ts_info(struct
> net_device *netdev,
>         struct lan743x_adapter *adapter = netdev_priv(netdev);
> 
>         ts_info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> -                                  SOF_TIMESTAMPING_RX_SOFTWARE |
> -                                  SOF_TIMESTAMPING_SOFTWARE |
>                                    SOF_TIMESTAMPING_TX_HARDWARE |
>                                    SOF_TIMESTAMPING_RX_HARDWARE |
>                                    SOF_TIMESTAMPING_RAW_HARDWARE;
> 
>         if (adapter->ptp.ptp_clock)
>                 ts_info->phc_index = ptp_clock_index(adapter->ptp.ptp_clock);
> -       else
> -               ts_info->phc_index = -1;
> 
>         ts_info->tx_types = BIT(HWTSTAMP_TX_OFF) |
>                             BIT(HWTSTAMP_TX_ON) |


for drivers/net/ethernet/microchip/lan743x_ethtool.c

Reviewed-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>