netdev - RE: [Intel-wired-lan] [iwl-next v1] ice: set correct dst VSI in only LAN filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB50132B1B6A58E0B103F265BA96972@PH0PR11MB5013.namprd11.prod.outlook.com>
Date: Fri, 30 Aug 2024 07:54:20 +0000
From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next v1] ice: set correct dst VSI in only
 LAN filters

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Michal Swiatkowski
> Sent: Monday, August 19, 2024 3:44 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Drewek, Wojciech
> <wojciech.drewek@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [iwl-next v1] ice: set correct dst VSI in only LAN
> filters
> 
> The filters set that will reproduce the problem:
> $ tc filter add dev $VF0_PR ingress protocol arp prio 0 flower \
> 	skip_sw dst_mac ff:ff:ff:ff:ff:ff action mirred egress \
> 	redirect dev $PF0
> $ tc filter add dev $VF0_PR ingress protocol arp prio 0 flower \
> 	skip_sw dst_mac ff:ff:ff:ff:ff:ff src_mac 52:54:00:00:00:10 \
> 	action mirred egress mirror dev $VF1_PR
> 
> Expected behaviour is to set all broadcast from VF0 to the LAN. If the
> src_mac match the value from filters, send packet to LAN and to VF1.
> 
> In this case both LAN_EN and LB_EN flags in switch is set in case of packet
> matching both filters. As dst VSI for the only LAN enable bit is PF VSI, the
> packet is being seen on PF. To fix this change dst VSI to the source VSI. It will
> block receiving any packet even when LB_EN is set by switch, because local
> loopback is clear on VF VSI during normal operation.
> 
> Side note: if the second filters action is redirect instead of mirror LAN_EN is
> clear, because switch is AND-ing LAN_EN from each matched filters and OR-
> ing LB_EN.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Fixes: 73b483b79029 ("ice: Manage act flags for switchdev offloads")
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>