netdev - RE: [PATCH net-next 0/8] Use max/min to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfb315c60376419ea2ea90df7e7ae2dc@AcuMS.aculab.com>
Date: Fri, 30 Aug 2024 08:40:18 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Jakub Kicinski' <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>
CC: Hongbo Li <lihongbo22@...wei.com>, "johannes@...solutions.net"
	<johannes@...solutions.net>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "allison.henderson@...cle.com"
	<allison.henderson@...cle.com>, "dsahern@...nel.org" <dsahern@...nel.org>,
	"pshelar@....org" <pshelar@....org>, "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "rds-devel@....oracle.com"
	<rds-devel@....oracle.com>, "dccp@...r.kernel.org" <dccp@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>, "linux-afs@...ts.infradead.org"
	<linux-afs@...ts.infradead.org>
Subject: RE: [PATCH net-next 0/8] Use max/min to simplify the code

From: Jakub Kicinski
> Sent: 27 August 2024 15:04
> 
> On Tue, 27 Aug 2024 07:45:02 +0300 Kalle Valo wrote:
> > > Do you mean some patches will go to other branches (such as mac80211)?
> >
> > Jakub means that your patchset had compilation errors, see the red on
> > patchwork:
> >
> > https://patchwork.kernel.org/project/netdevbpf/list/?series=882901&state=*&order=date
> 
> FWIW I prefer not to point noobs to the patchwork checks, lest they
> think it's a public CI and they can fling broken code at the list :(
> But yes, in case "code doesn't build" needs a further explanation:
> 
> net/core/pktgen.c: In function ‘pktgen_finalize_skb’:
> ./../include/linux/compiler_types.h:510:45: error: call to ‘__compiletime_assert_928’ declared with
> attribute error: min(datalen/frags, ((1UL) << 12)) signedness error
...
> ../net/core/pktgen.c:2796:28: note: in expansion of macro ‘min’
>  2796 |                 frag_len = min(datalen/frags, PAGE_SIZE);
>       |                            ^~~

I can't help feeling that a signed divide isn't intended here.
Which rather implies that both datalen and frags are signed types.
Whereas neither can be sensibly negative.
Perhaps that is the real bug?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)