netdev - Re: [PATCH v2 0/1] net/mlx5: Added cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36b5d976-1fcb-45b9-97dd-19f048997588@nvidia.com>
Date: Fri, 30 Aug 2024 12:51:43 +0300
From: Moshe Shemesh <moshe@...dia.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>, Mohamed Khalfella
	<mkhalfella@...estorage.com>
CC: <yzhong@...estorage.com>, Shay Drori <shayd@...dia.com>, Saeed Mahameed
	<saeedm@...dia.com>, <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Leon Romanovsky <leon@...nel.org>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Tariq Toukan
	<tariqt@...dia.com>
Subject: Re: [PATCH v2 0/1] net/mlx5: Added cond_resched() to crdump
 collection



On 8/30/2024 10:08 AM, Przemek Kitszel wrote:

> 
> On 8/30/24 01:58, Mohamed Khalfella wrote:
>> On 2024-08-29 15:38:55 -0600, Mohamed Khalfella wrote:
>>> Changes in v2:
>>> - Removed cond_resched() in mlx5_vsc_wait_on_flag(). The idea is that
>>>    usleep_range() should be enough.
>>> - Updated cond_resched() in mlx5_vsc_gw_read_block_fast every 128
>>>    iterations.
>>>
>>> v1: 
>>> https://lore.kernel.org/all/20240819214259.38259-1-mkhalfella@purestorage.com/
>>>
>>> Mohamed Khalfella (1):
>>>    net/mlx5: Added cond_resched() to crdump collection
>>>
>>>   drivers/net/ethernet/mellanox/mlx5/core/lib/pci_vsc.c | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> -- 
>>> 2.45.2
>>>
>>
>> Some how I missed to add reviewers were on v1 of this patch.
>>
> 
> You did it right, there is need to provide explicit tag, just engaging
> in the discussion is not enough. v2 is fine, so:
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

Reviewed-by: Moshe Shemesh <moshe@...dia.com>
And fixes tag should be:
Fixes: 8b9d8baae1de ("net/mlx5: Add Crdump support")

Thanks.