netdev - Re: [PATCH ipsec-next] xfrm: Initialise dir in xfrm_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240831082549.GD4063074@kernel.org>
Date: Sat, 31 Aug 2024 09:25:49 +0100
From: Simon Horman <horms@...nel.org>
To: Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
	Naresh Kamboju <naresh.kamboju@...aro.org>,
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH ipsec-next] xfrm: Initialise dir in xfrm_hash_rebuild()

+ Nathan

On Fri, Aug 30, 2024 at 06:01:50PM +0100, Simon Horman wrote:
> The cited commit removed the initialisation of dir in one place too
> many: it is still used within the loop this patch updates.
> 
> Compile tested only.
> 
> Fixes: 08c2182cf0b4 ("xfrm: policy: use recently added helper in more places")
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Closes: https://lore.kernel.org/netdev/CA+G9fYtemFfuhc7=eNyP3TezM9Euc8sFtHe4GDR4Z9XdHzXSJA@mail.gmail.com/
> Signed-off-by: Simon Horman <horms@...nel.org>

Nathan advises me that this fix is incomplete and
that he has sent a complete fix here:

https://lore.kernel.org/all/20240829-xfrm-restore-dir-assign-xfrm_hash_rebuild-v2-1-1cf8958f6e8e@kernel.org/

-- 
pw-bot: rejected