netdev - RE: [PATCH v1] netronome: nfp: Use min macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <151a6133edc74d07a4488cdd83090d1a@AcuMS.aculab.com>
Date: Sat, 31 Aug 2024 12:49:47 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Jakub Kicinski' <kuba@...nel.org>, Yan Zhen <yanzhen@...o.com>
CC: "louis.peens@...igine.com" <louis.peens@...igine.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"oss-drivers@...igine.com" <oss-drivers@...igine.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"opensource.kernel@...o.vom" <opensource.kernel@...o.vom>
Subject: RE: [PATCH v1] netronome: nfp: Use min macro

From: Jakub Kicinski
> Sent: 27 August 2024 15:24
> 
> On Tue, 27 Aug 2024 16:40:05 +0800 Yan Zhen wrote:
> > Using min macro not only makes the code more concise and readable
> > but also improves efficiency sometimes.
> 
> The code is fine, you're making it worse.
> 
> How many of those pointless min()/max() conversions do you have
> for drivers/net ?

Maybe someone who understands cochineal should change the pattern
so that is require one of the 'arguments' to be non-trivial.
(or perhaps just delete the script ;-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)