netdev - Re: [PATCH net-next v2 1/3] net: dsa: microchip: rename ksz8 series files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89aa2ceed7e14f3498b51f2d76f19132e0d77d35.camel@microchip.com>
Date: Mon, 2 Sep 2024 02:56:18 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<linux@...linux.org.uk>, <Woojung.Huh@...rochip.com>, <f.fainelli@...il.com>,
	<kuba@...nel.org>, <vtpieter@...il.com>, <UNGLinuxDriver@...rochip.com>,
	<edumazet@...gle.com>, <pabeni@...hat.com>
CC: <o.rempel@...gutronix.de>, <pieter.van.trappen@...n.ch>,
	<Tristram.Ha@...rochip.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/3] net: dsa: microchip: rename ksz8 series
 files

Hi Pieter, 

On Fri, 2024-08-30 at 16:12 +0200, vtpieter@...il.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> 
> 
> 
> diff --git a/drivers/net/dsa/microchip/Kconfig
> b/drivers/net/dsa/microchip/Kconfig
> index c1b906c05a02..d43535c9aa72 100644
> --- a/drivers/net/dsa/microchip/Kconfig
> +++ b/drivers/net/dsa/microchip/Kconfig
> @@ -1,14 +1,17 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  menuconfig NET_DSA_MICROCHIP_KSZ_COMMON
> -       tristate "Microchip KSZ8795/KSZ9477/LAN937x series switch
> support"
> +       tristate "Microchip KSZ8XXX/KSZ9477/LAN937X series switch
> support"
>         depends on NET_DSA
>         select NET_DSA_TAG_KSZ
>         select NET_DSA_TAG_NONE
>         select NET_IEEE8021Q_HELPERS
>         select DCB
>         help
> -         This driver adds support for Microchip KSZ9477 series
> switch and
> -         KSZ8795/KSZ88x3 switch chips.
> +         This driver adds support for Microchip KSZ9477 series,
> +         LAN937X series and KSZ8 series switch chips, being
> +         KSZ9477/9896/9897/9893/9563/9567,

You missed KSZ8567 and KSZ8563. Also it could be in order as suggested
by Tristram,
-  KSZ8863/8873, KSZ8895/8864, KSZ8794/8795/8765
-  KSZ9477/9897/9896/9567/8567
-  KSZ9893/9563/8563
-  LAN9370/9371/9372/9373/9374

> +         LAN9370/9371/9372/9373/9374, KSZ8863/8873, KSZ8895/8864 and
> +         KSZ8794/8795/8765.
> 
> 
> @@ -1,6 +1,13 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Microchip KSZ8795 switch driver
> + * Microchip KSZ8XXX series switch driver
> + *
> + * It supports the following switches:
> + * - KSZ8863, KSZ8873 aka KSZ88X3
> + * - KSZ8895, KSZ8864 aka KSZ8895 family

You can remove 'family' here, so as to be consistent. 

> + * - KSZ8794, KSZ8795, KSZ8765 aka KSZ87XX
> + * Note that it does NOT support:
> + * - KSZ8563, KSZ8567 - see KSZ9477 driver
>   *
>   * Copyright (C) 2017 Microchip Technology Inc.
>   *     Tristram Ha <Tristram.Ha@...rochip.com>
> @@ -23,7 +30,7 @@
>  #include <linux/phylink.h>
>