netdev - Re: [PATCH net-next v3 2/2] rxtimestamp.c: add the test for SOF_TIMESTAMPING_OPT_RX_SOFTWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtU+H5md7d/Svo0u@rli9-mobl>
Date: Mon, 2 Sep 2024 12:25:03 +0800
From: Philip Li <philip.li@...el.com>
To: Jason Xing <kerneljasonxing@...il.com>
CC: kernel test robot <lkp@...el.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<dsahern@...nel.org>, <willemb@...gle.com>, <oe-kbuild-all@...ts.linux.dev>,
	<netdev@...r.kernel.org>, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v3 2/2] rxtimestamp.c: add the test for
 SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER

On Mon, Sep 02, 2024 at 10:41:28AM +0800, Jason Xing wrote:
> On Mon, Sep 2, 2024 at 9:49 AM kernel test robot <lkp@...el.com> wrote:
> >
> > Hi Jason,
> >
> > kernel test robot noticed the following build errors:
> >
> > [auto build test ERROR on net-next/main]
> >
> > url:    https://github.com/intel-lab-lkp/linux/commits/Jason-Xing/net-timestamp-filter-out-report-when-setting-SOF_TIMESTAMPING_SOFTWARE/20240830-234014
> > base:   net-next/main
> > patch link:    https://lore.kernel.org/r/20240830153751.86895-3-kerneljasonxing%40gmail.com
> > patch subject: [PATCH net-next v3 2/2] rxtimestamp.c: add the test for SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER
> > :::::: branch date: 2 days ago
> > :::::: commit date: 2 days ago
> > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240902/202409020124.YybQQDrP-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/r/202409020124.YybQQDrP-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > >> rxtimestamp.c:102:6: error: use of undeclared identifier 'SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER'
> >      102 |                         | SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER },
> >          |                           ^
> > >> rxtimestamp.c:373:20: error: invalid application of 'sizeof' to an incomplete type 'struct test_case[]'
> >      373 |                         for (t = 0; t < ARRAY_SIZE(test_cases); t++) {
> >          |                                         ^~~~~~~~~~~~~~~~~~~~~~
> >    ./../kselftest.h:61:32: note: expanded from macro 'ARRAY_SIZE'
> >       61 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
> >          |                                ^~~~~
> >    rxtimestamp.c:380:13: error: invalid application of 'sizeof' to an incomplete type 'struct test_case[]'
> >      380 |                         if (t >= ARRAY_SIZE(test_cases))
> >          |                                  ^~~~~~~~~~~~~~~~~~~~~~
> >    ./../kselftest.h:61:32: note: expanded from macro 'ARRAY_SIZE'
> >       61 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
> >          |                                ^~~~~
> >    rxtimestamp.c:419:19: error: invalid application of 'sizeof' to an incomplete type 'struct test_case[]'
> >      419 |                 for (t = 0; t < ARRAY_SIZE(test_cases); t++) {
> >          |                                 ^~~~~~~~~~~~~~~~~~~~~~
> >    ./../kselftest.h:61:32: note: expanded from macro 'ARRAY_SIZE'
> >       61 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
> >          |                                ^~~~~
> >    4 errors generated.
> 
> I didn't get how it happened? I've already test it locally.
> 
> Is it because the test environment didn't update the header files by
> using the command like "make headers_install && cp -r
> usr/include/linux /usr/include/"?

Sorry about the false report, kindly ignore this. And thanks for the hint,
we will check to understand the root cause of this wrong report and fix the
bot asap.

> 
> If the applications or some userspace tools try to use the new flag,
> it should update the header file to sync the uapi file first.
> 
> Thanks,
> Jason
>