netdev - Re: [PATCH net-next v2 3/3] net: dsa: microchip: replace unclear KSZ8830 strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf9cb15d13e114cd8c361e4d411efe392b74711a.camel@microchip.com>
Date: Mon, 2 Sep 2024 14:48:39 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <vtpieter@...il.com>
CC: <Tristram.Ha@...rochip.com>, <andrew@...n.ch>, <linux@...linux.org.uk>,
	<olteanv@...il.com>, <davem@...emloft.net>, <Woojung.Huh@...rochip.com>,
	<linux-kernel@...r.kernel.org>, <pieter.van.trappen@...n.ch>,
	<f.fainelli@...il.com>, <kuba@...nel.org>, <UNGLinuxDriver@...rochip.com>,
	<edumazet@...gle.com>, <o.rempel@...gutronix.de>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH net-next v2 3/3] net: dsa: microchip: replace unclear
 KSZ8830 strings

Hi Pieter, 

On Mon, 2024-09-02 at 12:14 +0200, Pieter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Hi Arun,
> 
> > > From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> > > 
> > > Replace uppercase KSZ8830 with KSZ8863
> > 
> > Since KSZ8863/73 sharing same chip id, replacing KSZ8830 with
> > KSZ8863
> > is somewhat confusing. Can you elaborate here. I believe, it should
> > KSZ88X3_CHIP_ID.
> 
> I'm afraid there's no perfect solution here, it's the only chip here
> that can't be differentiated by its chip id I believe.
> 
> The reason I didn't go for KSZ88X3_CHIP_ID is that the enum requires
> a
> constant as well so `0x88x3` won't work and I wanted to avoid the
> following because it would be the only definition where the name and
> constant would not match:

IMO: It is understood that KSZ88x3 has chip id 0x8830, So the name and
constant does not match each other. 

> 
> --- a/include/linux/platform_data/microchip-ksz.h
> +++ b/include/linux/platform_data/microchip-ksz.h
> @@ -27,7 +27,7 @@ enum ksz_chip_id {
>         KSZ8795_CHIP_ID = 0x8795,
>         KSZ8794_CHIP_ID = 0x8794,
>         KSZ8765_CHIP_ID = 0x8765,
> -       KSZ8830_CHIP_ID = 0x8830,
> +       KSZ88X3_CHIP_ID = 0x8863,
>         KSZ8864_CHIP_ID = 0x8864,
>         KSZ8895_CHIP_ID = 0x8895
> 
> Technically it's possible of course, which one has your preference?

It is confusing like for upper case replacing with KSZ8863 and
lowercase with KSZ88x3. IMO it should be same for both. Have things
consistent. 

> 
> Cheers, Pieter