netdev - Re: [PATCH net-next v7 2/2] net: ti: icssg-prueth: Add support for PA Stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cfcb7f7-1779-463a-9e77-e0e09234a35f@siemens.com>
Date: Mon, 2 Sep 2024 09:22:42 +0200
From: Jan Kiszka <jan.kiszka@...mens.com>
To: MD Danish Anwar <danishanwar@...com>, Suman Anna <s-anna@...com>,
 Sai Krishna <saikrishnag@...vell.com>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Heiner Kallweit <hkallweit1@...il.com>, Diogo Ivo <diogo.ivo@...mens.com>,
 Kory Maincent <kory.maincent@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>,
 Roger Quadros <rogerq@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Santosh Shilimkar <ssantosh@...nel.org>, Nishanth Menon <nm@...com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 srk@...com, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH net-next v7 2/2] net: ti: icssg-prueth: Add support for PA
 Stats

On 22.08.24 14:26, MD Danish Anwar wrote:
> Add support for dumping PA stats registers via ethtool.
> Firmware maintained stats are stored at PA Stats registers.
> Also modify emac_get_strings() API to use ethtool_puts().
> 
> This commit also maintains consistency between miig_stats and pa_stats by
> - renaming the array icssg_all_stats to icssg_all_miig_stats
> - renaming the structure icssg_stats to icssg_miig_stats
> - renaming ICSSG_STATS() to ICSSG_MIIG_STATS()
> - changing order of stats related data structures and arrays so that data
>   structures of a certain stats type is clubbed together.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
>  drivers/net/ethernet/ti/icssg/icssg_ethtool.c |  19 ++-
>  drivers/net/ethernet/ti/icssg/icssg_prueth.c  |   6 +
>  drivers/net/ethernet/ti/icssg/icssg_prueth.h  |   9 +-
>  drivers/net/ethernet/ti/icssg/icssg_stats.c   |  31 +++-
>  drivers/net/ethernet/ti/icssg/icssg_stats.h   | 158 +++++++++++-------
>  5 files changed, 140 insertions(+), 83 deletions(-)
> 

...

> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index 53a3e44b99a2..f623a0f603fc 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -1182,6 +1182,12 @@ static int prueth_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  	}
>  
> +	prueth->pa_stats = syscon_regmap_lookup_by_phandle(np, "ti,pa-stats");
> +	if (IS_ERR(prueth->pa_stats)) {
> +		dev_err(dev, "couldn't get ti,pa-stats syscon regmap\n");
> +		return -ENODEV;

I was just beaten for potentially not being backward compatible, but
this is definitely not working with existing DTs, just ran into it.

Jan

-- 
Siemens AG, Technology
Linux Expert Center