netdev - Re: [PATCH net-next] net: lan743x: Use NSEC_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv0YxV5YW_KZUDyXxO9RE1Me9P=ZhSGFpRtHhzTSK0WJww@mail.gmail.com>
Date: Mon, 2 Sep 2024 14:30:40 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: bryan.whitehead@...rochip.com, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, richardcochran@...il.com, 
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: lan743x: Use NSEC_PER_SEC macro

On Mon, Sep 2, 2024 at 12:41 PM Jinjie Ruan <ruanjinjie@...wei.com> wrote:
>
> 1000000000L is number of ns per second, use NSEC_PER_SEC macro to replace
> it to make it more readable.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  drivers/net/ethernet/microchip/lan743x_ptp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
> index dcea6652d56d..9c2ec293c163 100644
> --- a/drivers/net/ethernet/microchip/lan743x_ptp.c
> +++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
> @@ -409,7 +409,7 @@ static int lan743x_ptpci_settime64(struct ptp_clock_info *ptpci,
>                                    ts->tv_sec);
>                         return -ERANGE;
>                 }
> -               if (ts->tv_nsec >= 1000000000L ||
> +               if (ts->tv_nsec >= NSEC_PER_SEC ||
>                     ts->tv_nsec < 0) {
>                         netif_warn(adapter, drv, adapter->netdev,
>                                    "ts->tv_nsec out of range, %ld\n",
> --
> 2.34.1

Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)