netdev - Re: [PATCH net-next v2 3/3] net: dsa: microchip: replace unclear KSZ8830 strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHvy4ApNq69g9edtmgUne4k+_P5T0xYOS-WaL5QWZin50+MMrg@mail.gmail.com>
Date: Mon, 2 Sep 2024 12:14:30 +0200
From: Pieter <vtpieter@...il.com>
To: Arun.Ramadoss@...rochip.com
Cc: andrew@...n.ch, olteanv@...il.com, davem@...emloft.net, 
	linux@...linux.org.uk, Woojung.Huh@...rochip.com, f.fainelli@...il.com, 
	kuba@...nel.org, UNGLinuxDriver@...rochip.com, edumazet@...gle.com, 
	pabeni@...hat.com, o.rempel@...gutronix.de, pieter.van.trappen@...n.ch, 
	Tristram.Ha@...rochip.com, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: dsa: microchip: replace unclear
 KSZ8830 strings

Hi Arun,

> > From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> >
> > Replace uppercase KSZ8830 with KSZ8863
>
> Since KSZ8863/73 sharing same chip id, replacing KSZ8830 with KSZ8863
> is somewhat confusing. Can you elaborate here. I believe, it should
> KSZ88X3_CHIP_ID.

I'm afraid there's no perfect solution here, it's the only chip here
that can't be differentiated by its chip id I believe.

The reason I didn't go for KSZ88X3_CHIP_ID is that the enum requires a
constant as well so `0x88x3` won't work and I wanted to avoid the
following because it would be the only definition where the name and
constant would not match:

--- a/include/linux/platform_data/microchip-ksz.h
+++ b/include/linux/platform_data/microchip-ksz.h
@@ -27,7 +27,7 @@ enum ksz_chip_id {
        KSZ8795_CHIP_ID = 0x8795,
        KSZ8794_CHIP_ID = 0x8794,
        KSZ8765_CHIP_ID = 0x8765,
-       KSZ8830_CHIP_ID = 0x8830,
+       KSZ88X3_CHIP_ID = 0x8863,
        KSZ8864_CHIP_ID = 0x8864,
        KSZ8895_CHIP_ID = 0x8895

Technically it's possible of course, which one has your preference?

Cheers, Pieter