netdev - Re: [PATCH -next 2/4] tun: Make use of str_disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtWYO-atol0Qx58h@smile.fi.intel.com>
Date: Mon, 2 Sep 2024 13:49:31 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Hongbo Li <lihongbo22@...wei.com>, kees@...nel.org,
	willemdebruijn.kernel@...il.com, jasowang@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	akpm@...ux-foundation.org, linux-hardening@...r.kernel.org,
	netdev@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper

On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
> On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
> > Use str_disabled_enabled() helper instead of open
> > coding the same.

...

> >  		netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n",
> > -			   arg ? "disabled" : "enabled");
> > +			   str_disabled_enabled(arg));
> 
> You don't explain the 'why'. How is this an improvement?
> nack on this and 2 similar networking changes you sent

Side opinion: This makes the messages more unified and not prone to typos
and/or grammatical mistakes. Unification allows to shrink binary due to
linker efforts on string literals deduplication.

That said, I see an improvement here, however it might be not recognised
as a Big Win.

And yes, I agree on the commit message poor explanations.

-- 
With Best Regards,
Andy Shevchenko