netdev - Re: [PATCH ipsec 1/2] xfrm: extract dst lookup parameters into a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHsH6GtRW4jHPMMWrkRGo8u6EZFxx4stYp_3SGLLEdfojYo5=g@mail.gmail.com>
Date: Mon, 2 Sep 2024 03:54:54 -0700
From: Eyal Birger <eyal.birger@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: steffen.klassert@...unet.com, herbert@...dor.apana.org.au, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, dsahern@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org, devel@...ux-ipsec.org
Subject: Re: [PATCH ipsec 1/2] xfrm: extract dst lookup parameters into a struct

Hi Simon,

On Mon, Sep 2, 2024 at 2:32 AM Simon Horman <horms@...nel.org> wrote:
>
> On Sun, Sep 01, 2024 at 04:57:36PM -0700, Eyal Birger wrote:
> > Preparation for adding more fields to dst lookup functions without
> > changing their signatures.
> >
> > Signed-off-by: Eyal Birger <eyal.birger@...il.com>
>
> ...
>
> > diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
>
> ...
>
> > @@ -277,9 +279,12 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x,
> >                       daddr = &x->props.saddr;
> >               }
> >
> > -             dst = __xfrm_dst_lookup(net, 0, 0, saddr, daddr,
> > -                                     x->props.family,
> > -                                     xfrm_smark_get(0, x));
> > +             memset(&params, 0, sizeof(params));
> > +             params.net = net;
> > +             params.saddr = saddr;
> > +             params.daddr = saddr;
>
> Hi Eyal,
>
> Should this be: params.daddr = daddr;
>                                ^^^^^
>
> daddr is flagged as set but otherwise unused by W=1 allmodconfig builds.
>

Sorry about this, thank you for this catch! will fix in v2.

Eyal.