netdev - Re: [PATCH net v7 0/3] ptp: ocp: fix serial port information export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024090313-crewless-nearly-3ee2@gregkh>
Date: Tue, 3 Sep 2024 10:40:23 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Vadim Fedorenko <vadfed@...a.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Jakub Kicinski <kuba@...nel.org>,
	Jonathan Lemon <jonathan.lemon@...il.com>,
	Jiri Slaby <jirislaby@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net v7 0/3] ptp: ocp: fix serial port information export

On Thu, Aug 29, 2024 at 11:36:00AM -0700, Vadim Fedorenko wrote:
> Starting v6.8 the serial port subsystem changed the hierarchy of devices
> and symlinks are not working anymore. Previous discussion made it clear
> that the idea of symlinks for tty devices was wrong by design [1].
> This series implements additional attributes to expose the information
> and removes symlinks for tty devices.
> 
> [1] https://lore.kernel.org/netdev/2024060503-subsonic-pupil-bbee@gregkh/
> 
> v6 -> v7:
> - fix issues with applying patches
> v5 -> v6:
> - split conversion to array to separate patch per Jiri's feedback
> - move changelog to cover letter
> v4 -> v5:
> - remove unused variable in ptp_ocp_tty_show
> v3 -> v4:
> - re-organize info printing to use ptp_ocp_tty_port_name()
> - keep uintptr_t to be consistent with other code
> v2 -> v3:
> - replace serial ports definitions with array and enum for index
> - replace pointer math with direct array access
> - nit in documentation spelling
> v1 -> v2:
> - add Documentation/ABI changes
> 
> Vadim Fedorenko (3):
>   ptp: ocp: convert serial ports to array
>   ptp: ocp: adjust sysfs entries to expose tty information
>   docs: ABI: update OCP TimeCard sysfs entries
> 
>  Documentation/ABI/testing/sysfs-timecard |  31 +++--
>  drivers/ptp/ptp_ocp.c                    | 168 ++++++++++++++---------
>  2 files changed, 119 insertions(+), 80 deletions(-)

Thanks for doing this:

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>