netdev - Re: [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240903104642.75303-1-takamitz@amazon.co.jp>
Date: Tue, 3 Sep 2024 19:46:42 +0900
From: Takamitsu Iwai <takamitz@...zon.co.jp>
To: <andrew@...n.ch>
CC: <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <intel-wired-lan@...ts.osuosl.org>, <kuba@...nel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<przemyslaw.kitszel@...el.com>, <takamitz@...zon.co.jp>
Subject: Re: [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx()

> Did the same sequence of read/writes happen before 0845d45e900c? Or
> did 0845d45e900c add additional writes, not just move them around?

The sequence of read/writes happened before 0845d45e900c because the similar
writel() exists in ew32() above the writel() moved by 0845d45e900c.

The commit 0845d45e900c moved writel() in e1000_clean_tx/rx_ring() to
e1000_configure_tx/rx() to avoid null pointer dereference. But since the same
writel() exists in e1000_configure_tx/rx(), we just needed to remove writel()
from e1000_clean_rx/tx_ring().