netdev - Re: [PATCH net-next v3 2/2] eth: fbnic: Add support to fetch group stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240903125201.GA1833@kernel.org>
Date: Tue, 3 Sep 2024 13:52:01 +0100
From: Simon Horman <horms@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	andrew@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, kernel-team@...a.com, sanmanpradhan@...a.com,
	sdf@...ichev.me, jdamato@...tly.com
Subject: Re: [PATCH net-next v3 2/2] eth: fbnic: Add support to fetch group
 stats

On Mon, Sep 02, 2024 at 10:39:07AM -0700, Mohsin Bashir wrote:
> Add support for group stats for mac. The fbnic_set_counter help preserve
> the default values for counters which are not touched by the driver.
> 
> The 'reset' flag in 'get_eth_mac_stats' allows to choose between
> resetting the counter to recent most value or fetching the aggregated
> values of the counter.
> 
> The 'fbnic_stat_rd64' read 64b stats counters in an atomic fashion using
> read-read-read approach. This allows to isolate cases where counter is
> moving too fast making accuracy of the counter questionable.
> 
> Command: ethtool -S eth0 --groups eth-mac
> Example Output:
> eth-mac-FramesTransmittedOK: 421644
> eth-mac-FramesReceivedOK: 3849708
> eth-mac-FrameCheckSequenceErrors: 0
> eth-mac-AlignmentErrors: 0
> eth-mac-OctetsTransmittedOK: 64799060
> eth-mac-FramesLostDueToIntMACXmitError: 0
> eth-mac-OctetsReceivedOK: 5134513531
> eth-mac-FramesLostDueToIntMACRcvError: 0
> eth-mac-MulticastFramesXmittedOK: 568
> eth-mac-BroadcastFramesXmittedOK: 454
> eth-mac-MulticastFramesReceivedOK: 276106
> eth-mac-BroadcastFramesReceivedOK: 26119
> eth-mac-FrameTooLongErrors: 0
> 
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> ---
> V3: Fix nit

It might have been better to mention what the nit was (spelling).

> 
> V2: https://lore.kernel.org/netdev/20240827205904.1944066-2-mohsin.bashr@gmail.com
> 
> V1: https://lore.kernel.org/netdev/20240822184944.3882360-1-mohsin.bashr@gmail.com/

This above notwithstanding, this looks good to me: It implements standard
statistics, and there was no substantial review from v1 and v2 to address.

Reviewed-by: Simon Horman <horms@...nel.org>