netdev - Re: [PATCH net-next] ipv4: Fix user space build failure due to header change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f5fe74a-277c-4b9c-b1fa-7e47fcd6a253@kernel.org>
Date: Tue, 3 Sep 2024 08:39:18 -0600
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, gnault@...hat.com
Subject: Re: [PATCH net-next] ipv4: Fix user space build failure due to header
 change

On 9/3/24 7:35 AM, Ido Schimmel wrote:
> RT_TOS() from include/uapi/linux/in_route.h is defined using
> IPTOS_TOS_MASK from include/uapi/linux/ip.h. This is problematic for
> files such as include/net/ip_fib.h that want to use RT_TOS() as without
> including both header files kernel compilation fails:
> 

...

> 
> Fix by changing include/net/ip_fib.h to include linux/ip.h. Note that
> usage of RT_TOS() should not spread further in the kernel due to recent
> work in this area.
> 
> Fixes: 1fa3314c14c6 ("ipv4: Centralize TOS matching")
> Reported-by: David Ahern <dsahern@...nel.org>
> Closes: https://lore.kernel.org/netdev/2f5146ff-507d-4cab-a195-b28c0c9e654e@kernel.org/
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  include/net/ip_fib.h          | 1 +
>  include/uapi/linux/in_route.h | 2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>


Thanks, Ido.