netdev - Re: [devel-ipsec] [PATCH ipsec, v3 2/2] xfrm: respect ip protocols rules criteria when performing dst lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ztcm8eCyoQ5d9B4R@moon.secunet.de>
Date: Tue, 3 Sep 2024 17:10:41 +0200
From: Antony Antony <antony.antony@...unet.com>
To: Eyal Birger <eyal.birger@...il.com>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <steffen.klassert@...unet.com>,
	<herbert@...dor.apana.org.au>, <paul.wouters@...en.io>, <antony@...nome.org>,
	<horms@...nel.org>, <devel@...ux-ipsec.org>, <netdev@...r.kernel.org>
Subject: Re: [devel-ipsec] [PATCH ipsec, v3 2/2] xfrm: respect ip protocols
 rules criteria when performing dst lookups

On Mon, Sep 02, 2024 at 17:07:10 -0700, Eyal Birger via Devel wrote:
> The series in the "fixes" tag added the ability to consider L4 attributes
> in routing rules.
> 
> The dst lookup on the outer packet of encapsulated traffic in the xfrm
> code was not adapted to this change, thus routing behavior that relies
> on L4 information is not respected.
> 
> Pass the ip protocol information when performing dst lookups.
> 
> Fixes: a25724b05af0 ("Merge branch 'fib_rules-support-sport-dport-and-proto-match'")
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>

Tested-by: Antony Antony <antony.antony@...unet.com>

 
> ---
> 
> v3: pass ipproto for non UDP/TCP encapsulated traffic as suggested by
>     Antony Antony

This works with ipproto ESP.
thnks Eyal. 

-antony