netdev - RE: [Intel-wired-lan] [PATCH iwl-net] igb: Always call igb_xdp_ring_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB51444D404D662D5C63F06C47E2932@PH0PR11MB5144.namprd11.prod.outlook.com>
Date: Tue, 3 Sep 2024 15:47:57 +0000
From: "Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>
To: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: Jesper Dangaard Brouer <hawk@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, Sriram Yagnaraman <sriram.yagnaraman@...csson.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, John Fastabend
	<john.fastabend@...il.com>, Alexei Starovoitov <ast@...nel.org>, "Kurt
 Kanzenbach" <kurt@...utronix.de>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Sriram Yagnaraman
	<sriram.yagnaraman@....tech>, Benjamin Steinke
	<benjamin.steinke@...s-audio.com>, Eric Dumazet <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, Jakub Kicinski <kuba@...nel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] igb: Always call
 igb_xdp_ring_update_tail() under Tx lock

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Kurt
> Kanzenbach
> Sent: Thursday, August 22, 2024 12:42 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: Jesper Dangaard Brouer <hawk@...nel.org>; Daniel Borkmann
> <daniel@...earbox.net>; Sriram Yagnaraman
> <sriram.yagnaraman@...csson.com>; Sebastian Andrzej Siewior
> <bigeasy@...utronix.de>; Kurt Kanzenbach <kurt@...utronix.de>; John Fastabend
> <john.fastabend@...il.com>; Alexei Starovoitov <ast@...nel.org>; Sriram
> Yagnaraman <sriram.yagnaraman@....tech>; Benjamin Steinke
> <benjamin.steinke@...s-audio.com>; Eric Dumazet <edumazet@...gle.com>;
> netdev@...r.kernel.org; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; intel-
> wired-lan@...ts.osuosl.org; Jakub Kicinski <kuba@...nel.org>;
> bpf@...r.kernel.org; Paolo Abeni <pabeni@...hat.com>; David S. Miller
> <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-net] igb: Always call igb_xdp_ring_update_tail()
> under Tx lock
> 
> From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
> 
> Always call igb_xdp_ring_update_tail() under __netif_tx_lock, add a comment and
> lockdep assert to indicate that. This is needed to share the same TX ring between
> XDP, XSK and slow paths. Furthermore, the current XDP implementation is racy on
> tail updates.
> 
> Fixes: 9cbc948b5a20 ("igb: add XDP support")
> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@....tech>
> [Kurt: Add lockdep assert and fixes tag]
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 

Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@...el.com>