netdev - Re: [PATCH net-next] l2tp: remove unneeded null check in l2tp_v2_session_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <332ef891-510e-4382-804c-bc2245276ea7@stanley.mountain>
Date: Tue, 3 Sep 2024 11:02:32 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Simon Horman <horms@...nel.org>
Cc: James Chapman <jchapman@...alix.com>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, dsahern@...nel.org, tparkin@...alix.com,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] l2tp: remove unneeded null check in
 l2tp_v2_session_get_next

On Tue, Sep 03, 2024 at 08:24:17AM +0100, Simon Horman wrote:
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/r/202408111407.HtON8jqa-lkp@intel.com/
> > CC: Dan Carpenter <dan.carpenter@...aro.org>
> > Signed-off-by: James Chapman <jchapman@...alix.com>
> > Signed-off-by: Tom Parkin <tparkin@...alix.com>
> 
> And as you posted the patch, it would be slightly more intuitive
> if your SoB line came last. But I've seen conflicting advice about
> the order of tags within the past weeks.

It should be in chronological order.

People generally aren't going to get too fussed about the order except the
Signed-off-by tags.  Everyone who handles the patch adds their Signed-off-by to
the end.  Right now it looks like James wrote the patch and then Tom is the
maintainer who merged it.  Co-developed-by?

regards,
dan carpenter