netdev - Re: [PATCH can-next v5 00/20] can: rockchip_canfd: add support for CAN-FD IP core found on Rockchip RK3568

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904-meticulous-original-sturgeon-ad2db3-mkl@pengutronix.de>
Date: Wed, 4 Sep 2024 11:19:42 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Heiko Stübner <heiko@...ech.de>
Cc: kernel@...gutronix.de, Alibek Omarov <a1ba.omarov@...il.com>, 
	Vincent Mailhol <mailhol.vincent@...adoo.fr>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Elaine Zhang <zhangqing@...k-chips.com>, 
	David Jander <david.jander@...tonic.nl>, Simon Horman <horms@...nel.org>, linux-can@...r.kernel.org, 
	netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, David Jander <david@...tonic.nl>
Subject: Re: [PATCH can-next v5 00/20] can: rockchip_canfd: add support for
 CAN-FD IP core found on Rockchip RK3568

On 04.09.2024 10:55:21, Heiko Stübner wrote:
> Hi Marc,
> 
> Am Mittwoch, 4. September 2024, 10:12:44 CEST schrieb Marc Kleine-Budde:
> > This series adds support for the CAN-FD IP core found on the Rockchip
> > RK3568.
> > 
> > The IP core is a bit complicated and has several documented errata.
> > The driver is added in several stages, first the base driver including
> > the RX-path. Then several workarounds for errata and the TX-path, and
> > finally features like hardware time stamping, loop-back mode and
> > bus error reporting.
> > 
> > regards,
> > Marc
> > 
> > Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> 
> I have neither CAN knowledge, nor hardware to test, but the integration
> itself looks pretty easy and straight-forward.
> 
> Not sure how much it helps, but at this moment I assume you know what
> you're doing with respect to the CAN controller ;-)

I hope so :) The controller has some flaws :/

> Rest of the series (that hasn't got a Rb):
> 
> Acked-by: Heiko Stuebner <heiko@...ech.de>

Thanks.

> How/when are you planning on applying stuff?
> 
> I.e. if you're going to apply things still for 6.12, you could simply take
> the whole series if the dts patches still apply to your tree ;-)

Actually I've already started my PR workflow, but I'll address your
review feedback, add your tags and send a new PR today. This will go via
net-next into v6.12.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)