netdev - Re: [PATCH net-next v3] net: enetc: Replace ifdef with IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904111342.2lboi53cl4pav4a5@skbuf>
Date: Wed, 4 Sep 2024 14:13:42 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Martyn Welch <martyn.welch@...labora.com>,
	Claudiu Manoil <claudiu.manoil@....com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...labora.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: enetc: Replace ifdef with IS_ENABLED

On Wed, Sep 04, 2024 at 12:11:31PM +0100, Vadim Fedorenko wrote:
> On 04/09/2024 11:51, Martyn Welch wrote:
> > The enetc driver uses ifdefs when checking whether
> > CONFIG_FSL_ENETC_PTP_CLOCK is enabled in a number of places. This works
> > if the driver is compiled in but fails if the driver is available as a
> > kernel module. Replace the instances of ifdef with use of the IS_ENABLED
> > macro, that will evaluate as true when this feature is built as a kernel
> > module and follows the kernel's coding style.
> > 
> > Signed-off-by: Martyn Welch <martyn.welch@...labora.com>
> > Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> 
> If there will be v4, please, put yours SoB as the last tag after all
> other tags.
> 
> Thanks,
> Vadim

What's the deal with this? If I give my review tag now, and the patch
will subsequently be applied, my Reviewed-by: tag will also appear after
his SoB.