netdev - Re: [PATCH net-next 03/20] arm64: dts: rockchip: mecsbc: add CAN0 and CAN1 interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904-resolute-mutant-bull-8000b7-mkl@pengutronix.de>
Date: Wed, 4 Sep 2024 13:57:42 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	linux-can@...r.kernel.org, kernel@...gutronix.de, David Jander <david@...tonic.nl>, 
	Alibek Omarov <a1ba.omarov@...il.com>, Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH net-next 03/20] arm64: dts: rockchip: mecsbc: add CAN0
 and CAN1 interfaces

On 04.09.2024 13:51:52, Krzysztof Kozlowski wrote:
> On 04/09/2024 11:38, Marc Kleine-Budde wrote:
> > From: David Jander <david@...tonic.nl>
> > 
> > This patch adds support for the CAN0 and CAN1 interfaces to the board.
> > 
> > Signed-off-by: David Jander <david@...tonic.nl>
> > Tested-by: Alibek Omarov <a1ba.omarov@...il.com>
> > Link: https://patch.msgid.link/20240904-rockchip-canfd-v5-3-8ae22bcb27cc@pengutronix.de
> > [mkl: fixed order of phandles]
> > Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> > Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts | 14 ++++++++++++++
> 
> DTS patches should never be taken via net/can or or any other driver
> subsystem.

Ok.

> DTS is independent hardware description. Embedding it here suggests
> there is dependency thus ABI break.

It might suggest, but it isn't.

> Please drop all DTS patches and never apply them via net.

Ok, will send an updated PR to net-next and an independent PR to
upstream the DTS changes.

regards
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)