netdev - Re: [PATCH net-next] net: lan743x: Use NSEC_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03dd432b-ee79-4d82-b8b8-83e04053acea@lunn.ch>
Date: Wed, 4 Sep 2024 14:16:16 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: bryan.whitehead@...rochip.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, richardcochran@...il.com,
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: lan743x: Use NSEC_PER_SEC macro

> > And the next question is, why is the driver checking this? It would
> > make more sense that the PTP core checked this before calling
> > ptp->info->settime64()
> 
> There are 2 places call ptp->info->settime64(), it may make more sense
> to check timespec64_valid() here and remove these check internal like
> lan743x_ptp.c?
> 
> drivers/net/phy/micrel.c:4721:          ptp->settime64(ptp, &ts);
> drivers/ptp/ptp_clock.c:103:    return  ptp->info->settime64(ptp->info, tp);

Yes, please extend the core.

	Andrew