netdev - Re: [PATCH 5/5] ALSA: firewire: use nonatomic PCM operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmjrh06d.wl-tiwai@suse.de>
Date: Wed, 04 Sep 2024 18:07:54 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Takashi Sakamoto <o-takashi@...amocchi.jp>
Cc: tiwai@...e.de,
	linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org,
	apais@...ux.microsoft.com,
	edmund.raile@...tonmail.com,
	linux-media@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] ALSA: firewire: use nonatomic PCM operation

On Wed, 04 Sep 2024 14:51:54 +0200,
Takashi Sakamoto wrote:
> 
> In the former commits, the callback of isochronous context runs on usual
> work process. In the case, ALSA PCM device has a flag, nonatomic, to
> acquire mutex lock instead of spin lock for PCM substream group.
> 
> This commit uses the flag. It has an advantage in the case that ALSA PCM
> application uses the large size of intermediate buffer, since it takes
> too long time even in tasklet softIRQ to process many of isochronous
> packets, then result in the delay of system event due to disabled IRQ so
> long. It is avertible to switch to nonatomic operation.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

Feel free to take my ack:

Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi