netdev - Re: [PATCH net] ila: call nf_unregister_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904173851.GA24759@breakpoint.cc>
Date: Wed, 4 Sep 2024 19:38:51 +0200
From: Florian Westphal <fw@...len.de>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	syzbot <syzkaller@...glegroups.com>,
	Tom Herbert <tom@...bertland.com>, Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net] ila: call nf_unregister_net_hooks() sooner

Eric Dumazet <edumazet@...gle.com> wrote:
> syzbot found an use-after-free Read in ila_nf_input [1]
> 
> Issue here is that ila_xlat_exit_net() frees the rhashtable,
> then call nf_unregister_net_hooks().
> 
> It should be done in the reverse way, with a synchronize_rcu().
> 
> This is a good match for a pre_exit() method.

Indeed, thanks Eric.

Reviewed-by: Florian Westphal <fw@...len.de>