netdev - Re: [PATCH net] selftests: net: enable bind tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904174533.8070-1-kuniyu@amazon.com>
Date: Wed, 4 Sep 2024 10:45:33 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <jamie.bainbridge@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <joannelkoong@...il.com>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <shuah@...nel.org>
Subject: Re: [PATCH net] selftests: net: enable bind tests

From: Jamie Bainbridge <jamie.bainbridge@...il.com>
Date: Wed,  4 Sep 2024 16:12:26 +1000
> bind_wildcard is compiled but not run, bind_timewait is not compiled.
> 
> These two tests complete in a very short time, use the test harness
> properly, and seem reasonable to enable.
> 
> The author of the tests confirmed via email that these were
> intended to be run.
> 
> Enable these two tests.
> 
> Fixes: 13715acf8ab5 ("selftest: Add test for bind() conflicts.")
> Fixes: 2c042e8e54ef ("tcp: Add selftest for bind() and TIME_WAIT.")
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@...il.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Thanks!


> ---
>  tools/testing/selftests/net/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 8eaffd7a641c5d6bb5c63e3015fdd9f32c114550..9d5aa817411b653ac130a1a581d933180a597ce5 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -85,7 +85,8 @@ TEST_GEN_PROGS += so_incoming_cpu
>  TEST_PROGS += sctp_vrf.sh
>  TEST_GEN_FILES += sctp_hello
>  TEST_GEN_FILES += ip_local_port_range
> -TEST_GEN_FILES += bind_wildcard
> +TEST_GEN_PROGS += bind_wildcard
> +TEST_GEN_PROGS += bind_timewait
>  TEST_PROGS += test_vxlan_mdb.sh
>  TEST_PROGS += test_bridge_neigh_suppress.sh
>  TEST_PROGS += test_vxlan_nolocalbypass.sh
> -- 
> 2.39.2
>