netdev - Re: [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904064101.8548-1-enjuk@amazon.com>
Date: Wed, 4 Sep 2024 15:41:01 +0900
From: Kohei Enju <enjuk@...zon.com>
To: <takamitz@...zon.co.jp>
CC: <andrew@...n.ch>, <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <intel-wired-lan@...ts.osuosl.org>, <kuba@...nel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<przemyslaw.kitszel@...el.com>, Kohei Enju <enjuk@...zon.com>
Subject: Re: [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx()

> My colleague, Kohei, tested the patch with a real hardware and will provide his
> Tested-by shortly.

I have tested the patch using my physical hardware, an Intel Ethernet controller I219-V. The device was properly attached by the e1000e driver and functioned correctly. The test was performed on a custom kernel based on kernel-core-6.10.6-200.fc40.x86_64.

The PCI device is identified as an Intel Corporation Ethernet Connection (17) I219-V (rev 11), with vendor ID 0x8086 and device ID 0x1a1d. This device ID matches the E1000_DEV_ID_PCH_ADP_I219_V17 definition in the e1000e driver code.
```
$ lspci | grep -i ethernet
00:1f.6 Ethernet controller: Intel Corporation Ethernet Connection (17) I219-V (rev 11)

$ cat /sys/bus/pci/devices/0000:00:1f.6/{vendor,device}
0x8086
0x1a1d

$ grep -ri 0x1a1d ~/ghq/github.com/torvalds/linux/drivers/net/ethernet/intel/e1000e
/home/kohei/ghq/github.com/torvalds/linux/drivers/net/ethernet/intel/e1000e/hw.h:#define E1000_DEV_ID_PCH_ADP_I219_V17          0x1A1D
```

So this testing confirms that the patch does not introduce any regressions for this specific hardware configuration.

Tested-by: Kohei Enju <enjuk@...zon.com>
Thanks!