netdev - [PATCH net-next 03/15] net: sparx5: Remove setting of RX software timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904074922.256275-4-gal@nvidia.com>
Date: Wed, 4 Sep 2024 10:49:10 +0300
From: Gal Pressman <gal@...dia.com>
To: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, Jay Vosburgh <jv@...sburgh.net>, Andy Gospodarek
	<andy@...yhouse.net>, Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol
	<mailhol.vincent@...adoo.fr>, Shyam Sundar S K <Shyam-sundar.S-k@....com>,
	Sudarsana Kalluru <skalluru@...vell.com>, Manish Chopra
	<manishc@...vell.com>, Michael Chan <michael.chan@...adcom.com>, Pavan Chebbi
	<pavan.chebbi@...adcom.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>, Sunil Goutham
	<sgoutham@...vell.com>, Potnuri Bharat Teja <bharat@...lsio.com>, "Christian
 Benvenuti" <benve@...co.com>, Satish Kharat <satishkh@...co.com>, "Claudiu
 Manoil" <claudiu.manoil@....com>, Vladimir Oltean <vladimir.oltean@....com>,
	Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, Clark Wang
	<xiaoning.wang@....com>, Dimitris Michailidis <dmichail@...gible.com>, "Yisen
 Zhuang" <yisen.zhuang@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
	"Jijie Shao" <shaojijie@...wei.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Marcin Wojtas <marcin.s.wojtas@...il.com>, Russell King
	<linux@...linux.org.uk>, "Geetha sowjanya" <gakula@...vell.com>, Subbaraya
 Sundeep <sbhatta@...vell.com>, hariprasad <hkelam@...vell.com>, Ido Schimmel
	<idosch@...dia.com>, "Petr Machata" <petrm@...dia.com>, Bryan Whitehead
	<bryan.whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>, Horatiu
 Vultur <horatiu.vultur@...rochip.com>, Lars Povlsen
	<lars.povlsen@...rochip.com>, Steen Hegelund <Steen.Hegelund@...rochip.com>,
	Daniel Machon <daniel.machon@...rochip.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Shannon Nelson <shannon.nelson@....com>,
	Brett Creeley <brett.creeley@....com>, Sergey Shtylyov <s.shtylyov@....ru>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>, "Edward
 Cree" <ecree.xilinx@...il.com>, Martin Habets <habetsm.xilinx@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
	<joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Siddharth Vadapalli <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>,
	MD Danish Anwar <danishanwar@...com>, Linus Walleij <linusw@...nel.org>,
	"Imre Kaloz" <kaloz@...nwrt.org>, Richard Cochran <richardcochran@...il.com>,
	"Willem de Bruijn" <willemdebruijn.kernel@...il.com>, Gal Pressman
	<gal@...dia.com>, Carolina Jubran <cjubran@...dia.com>, Rahul Rameshbabu
	<rrameshbabu@...dia.com>
Subject: [PATCH net-next 03/15] net: sparx5: Remove setting of RX software timestamp

The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.

Reviewed-by: Carolina Jubran <cjubran@...dia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
Signed-off-by: Gal Pressman <gal@...dia.com>
---
 .../net/ethernet/microchip/sparx5/sparx5_ethtool.c    | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c b/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c
index 4f800c1a435d..d898a7238b48 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c
@@ -1194,16 +1194,13 @@ static int sparx5_get_ts_info(struct net_device *dev,
 
 	phc = &sparx5->phc[SPARX5_PHC_PORT];
 
-	info->phc_index = phc->clock ? ptp_clock_index(phc->clock) : -1;
-	if (info->phc_index == -1) {
-		info->so_timestamping |= SOF_TIMESTAMPING_TX_SOFTWARE |
-					 SOF_TIMESTAMPING_RX_SOFTWARE |
-					 SOF_TIMESTAMPING_SOFTWARE;
+	if (phc->clock) {
+		info->phc_index = ptp_clock_index(phc->clock);
+	} else {
+		info->so_timestamping |= SOF_TIMESTAMPING_TX_SOFTWARE;
 		return 0;
 	}
 	info->so_timestamping |= SOF_TIMESTAMPING_TX_SOFTWARE |
-				 SOF_TIMESTAMPING_RX_SOFTWARE |
-				 SOF_TIMESTAMPING_SOFTWARE |
 				 SOF_TIMESTAMPING_TX_HARDWARE |
 				 SOF_TIMESTAMPING_RX_HARDWARE |
 				 SOF_TIMESTAMPING_RAW_HARDWARE;
-- 
2.40.1