netdev - Re: [PATCH net] sched: sch_cake: fix bulk flow accounting logic for host fairness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172553042950.1338142.999328518611522439.git-patchwork-notify@kernel.org>
Date: Thu, 05 Sep 2024 10:00:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Toke Høiland-Jørgensen <toke@...hat.com>@codeaurora.org
Cc: toke@...e.dk, jhs@...atatu.com, xiyou.wangcong@...il.com,
 jiri@...nulli.us, gamanakis@...il.com, davem@...emloft.net,
 syzbot+7fe7b81d602cc1e6b94d@...kaller.appspotmail.com, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, cake@...ts.bufferbloat.net,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] sched: sch_cake: fix bulk flow accounting logic for host
 fairness

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Tue,  3 Sep 2024 18:08:45 +0200 you wrote:
> In sch_cake, we keep track of the count of active bulk flows per host,
> when running in dst/src host fairness mode, which is used as the
> round-robin weight when iterating through flows. The count of active
> bulk flows is updated whenever a flow changes state.
> 
> This has a peculiar interaction with the hash collision handling: when a
> hash collision occurs (after the set-associative hashing), the state of
> the hash bucket is simply updated to match the new packet that collided,
> and if host fairness is enabled, that also means assigning new per-host
> state to the flow. For this reason, the bulk flow counters of the
> host(s) assigned to the flow are decremented, before new state is
> assigned (and the counters, which may not belong to the same host
> anymore, are incremented again).
> 
> [...]

Here is the summary with links:
  - [net] sched: sch_cake: fix bulk flow accounting logic for host fairness
    https://git.kernel.org/netdev/net/c/546ea84d07e3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html