netdev - Re: [PATCH net-next] net: ftgmac100: Fix potential NULL dereference in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv2ELPAGOyTVnRUs3GzuSsA2p2+zBt8HCSqrVNPEfoNPHQ@mail.gmail.com>
Date: Thu, 5 Sep 2024 15:39:32 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Jacky Chou <jacky_chou@...eedtech.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: ftgmac100: Fix potential NULL dereference
 in error handling

On Thu, Sep 5, 2024 at 11:44 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> We might not have a phy so we need to check for NULL before calling
> phy_stop(netdev->phydev) or it could lead to an Oops.
>
> Fixes: e24a6c874601 ("net: ftgmac100: Get link speed and duplex for NC-SI")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---

Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)