[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240905102417.232890-1-maxime.chevallier@bootlin.com>
Date: Thu, 5 Sep 2024 12:24:13 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: davem@...emloft.net,
Michal Kubecek <mkubecek@...e.cz>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
thomas.petazzoni@...tlin.com,
Andrew Lunn <andrew@...n.ch>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Russell King <linux@...linux.org.uk>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Herve Codina <herve.codina@...tlin.com>,
Florian Fainelli <f.fainelli@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Oleksij Rempel <o.rempel@...gutronix.de>,
Simon Horman <horms@...nel.org>
Subject: [PATCH ethtool-next v3 0/3] Introduce PHY listing and targeting
Hello,
This series adds the ethtool-side support to list PHYs associated to a
netdevice, as well as allowing to target PHYs for some commands :
- PSE-PD commands
- Cable testing commands
- PLCA commands
The V3 addresses Michal's reviews, introducing better error messages,
and documenting in the manpage the possible values for the 0 phy index.
The PHY-targetting commands look like this:
ethtool --phy 1 --cable-test eth0
Note that the --phy parameter gets passed at the beginning of the
command-line. This allows getting a generic command-line parsing code,
easy to write, but at the expense of maybe being a bit counter intuitive.
Another option could be to add a "phy" parameter to all the supported
commands, let me know if you think this looks too bad.
Patch 1 deals with the ability to pass a PHY index to the relevant
commands.
Patch 2 implements the --show-phys command. This command uses a netlink
DUMP request to list the PHYs, and introduces the ability to perform
filtered DUMP request, where the netdev index gets passed in the DUMP
request header.
Thanks,
Maxime
[1]: https://lore.kernel.org/netdev/20240821151009.1681151-1-maxime.chevallier@bootlin.com/
Link to V2:
Link to V1: https://lore.kernel.org/netdev/20240103142950.235888-1-maxime.chevallier@bootlin.com/
Maxime Chevallier (3):
update UAPI header copies
ethtool: Allow passing a PHY index for phy-targetting commands
ethtool: Introduce a command to list PHYs
Makefile.am | 1 +
ethtool.8.in | 57 +++++++++++++++++
ethtool.c | 33 +++++++++-
internal.h | 1 +
netlink/cable_test.c | 4 +-
netlink/extapi.h | 1 +
netlink/msgbuff.c | 52 ++++++++++++----
netlink/msgbuff.h | 3 +
netlink/nlsock.c | 38 ++++++++++++
netlink/nlsock.h | 2 +
netlink/phy.c | 116 +++++++++++++++++++++++++++++++++++
netlink/plca.c | 4 +-
netlink/pse-pd.c | 4 +-
uapi/linux/ethtool.h | 16 +++++
uapi/linux/ethtool_netlink.h | 25 ++++++++
15 files changed, 338 insertions(+), 19 deletions(-)
create mode 100644 netlink/phy.c
--
2.46.0
Powered by blists - more mailing lists