netdev - Re: [PATCH net-next] sfc: siena: rip out rss-context dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240905135636.GI1722938@kernel.org>
Date: Thu, 5 Sep 2024 14:56:36 +0100
From: Simon Horman <horms@...nel.org>
To: edward.cree@....com
Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, pabeni@...hat.com,
	Edward Cree <ecree.xilinx@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sfc: siena: rip out rss-context dead code

On Wed, Sep 04, 2024 at 07:11:56PM +0100, edward.cree@....com wrote:
> From: Edward Cree <ecree.xilinx@...il.com>
> 
> Siena hardware does not support custom RSS contexts, but when the
>  driver was forked from sfc.ko, some of the plumbing for them was
>  copied across from the common code.  Actually trying to use them
>  would lead to EOPNOTSUPP as the relevant efx_nic_type methods were
>  not populated.
> Remove this dead code from the Siena driver.
> 
> Signed-off-by: Edward Cree <ecree.xilinx@...il.com>

Thanks, this looks like a clean removal of dead code to me.

Reviewed-by: Simon Horman <horms@...nel.org>