netdev - Re: [PATCH v6 net-next 02/15] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240905080502.3246e040@kernel.org>
Date: Thu, 5 Sep 2024 08:05:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>, Madhu Chittim
 <madhu.chittim@...el.com>, Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Simon Horman <horms@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>, Jamal Hadi Salim
 <jhs@...atatu.com>, Donald Hunter <donald.hunter@...il.com>,
 anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
 intel-wired-lan@...ts.osuosl.org, edumazet@...gle.com
Subject: Re: [PATCH v6 net-next 02/15] netlink: spec: add shaper YAML spec

On Thu, 5 Sep 2024 16:51:00 +0200 Paolo Abeni wrote:
> On 9/5/24 03:03, Jakub Kicinski wrote:
> > On Wed,  4 Sep 2024 15:53:34 +0200 Paolo Abeni wrote:  
> >> +      -
> >> +        name: node
> >> +        type: nest
> >> +        nested-attributes: node-info
> >> +        doc: |
> >> +           Describes the node shaper for a @group operation.
> >> +           Differently from @leaves and @shaper allow specifying
> >> +           the shaper parent handle, too.  
> > 
> > Parent handle is inside node scope? Why are leaves outside and parent
> > inside? Both should be at the same scope, preferably main scope.  
> 
> The group() op receives as arguments, in the main scope:
> 
> ifindex
> node
> leaves
> 
> 'parent' is a nested attribute for 'node', exactly as 'handle'. We need 
> to specify both to identify the 'node' itself (via the 'handle') and to 
> specify where in the hierarchy the 'node' will be located (via the 
> 'parent'). Do I read correctly that you would prefer:
> 
> ifindex
> node_handle
> node_parent
> leaves

I don't see example uses in the cover letter or the test so there's 
a good chance I'm missing something, but... why node_parent?
The only thing you need to know about the parent is its handle,
so just "parent", right?

Also why node_handle? Just "handle", and other attrs of the node can
live in the main scope.

Unless you have a strong reason to do this to simplify the code -
"from netlink perspective" it looks like unnecessary nesting.
The operation arguments describe the node, there's no need to nest
things in another layer.