netdev - Re: [PATCHv3 net-next 2/9] net: ibm: emac: manage emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc0f5eec-12c6-4d26-a8a8-41e7abed9eae@lunn.ch>
Date: Thu, 5 Sep 2024 23:17:31 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org,
	jacob.e.keller@...el.com, horms@...nel.org, sd@...asysnail.net,
	chunkeey@...il.com
Subject: Re: [PATCHv3 net-next 2/9] net: ibm: emac: manage emac_irq with devm

On Thu, Sep 05, 2024 at 01:14:59PM -0700, Rosen Penev wrote:
> It's the last to go in remove. Safe to let devm handle it.
> 
> Also move request_irq to probe for clarity. It's removed in _remove not
> close.
> 
> Use dev_err_probe instead of printk. Handles EPROBE_DEFER automatically.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew