netdev - Re: [PATCH net 0/6][pull request] ice: fix synchronization between .ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172550223126.1227714.3911146774586738228.git-patchwork-notify@kernel.org>
Date: Thu, 05 Sep 2024 02:10:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, netdev@...r.kernel.org, larysa.zaremba@...el.com,
 wojciech.drewek@...el.com, michal.kubiak@...el.com, jacob.e.keller@...el.com,
 amritha.nambiar@...el.com, przemyslaw.kitszel@...el.com,
 sridhar.samudrala@...el.com, maciej.fijalkowski@...el.com,
 magnus.karlsson@...el.com, ast@...nel.org, daniel@...earbox.net,
 hawk@...nel.org, john.fastabend@...il.com, bpf@...r.kernel.org
Subject: Re: [PATCH net 0/6][pull request] ice: fix synchronization between
 .ndo_bpf() and reset

Hello:

This series was applied to netdev/net.git (main)
by Tony Nguyen <anthony.l.nguyen@...el.com>:

On Tue,  3 Sep 2024 11:30:26 -0700 you wrote:
> Larysa Zaremba says:
> 
> PF reset can be triggered asynchronously, by tx_timeout or by a user. With some
> unfortunate timings both ice_vsi_rebuild() and .ndo_bpf will try to access and
> modify XDP rings at the same time, causing system crash.
> 
> The first patch factors out rtnl-locked code from VSI rebuild code to avoid
> deadlock. The following changes lock rebuild and .ndo_bpf() critical sections
> with an internal mutex as well and provide complementary fixes.
> 
> [...]

Here is the summary with links:
  - [net,1/6] ice: move netif_queue_set_napi to rtnl-protected sections
    https://git.kernel.org/netdev/net/c/2a5dc090b92c
  - [net,2/6] ice: protect XDP configuration with a mutex
    https://git.kernel.org/netdev/net/c/2504b8405768
  - [net,3/6] ice: check for XDP rings instead of bpf program when unconfiguring
    https://git.kernel.org/netdev/net/c/f50c68763436
  - [net,4/6] ice: check ICE_VSI_DOWN under rtnl_lock when preparing for reset
    https://git.kernel.org/netdev/net/c/d8c40b9d3a6c
  - [net,5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code
    https://git.kernel.org/netdev/net/c/7e3b407ccbea
  - [net,6/6] ice: do not bring the VSI up, if it was down before the XDP setup
    https://git.kernel.org/netdev/net/c/04c7e14e5b0b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html