netdev - Re: [PATCH net-next v2 3/4] enic: Report per queue statistics in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240905183142.424c1d72@kernel.org>
Date: Thu, 5 Sep 2024 18:31:42 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Nelson Escobar <neescoba@...co.com>
Cc: netdev@...r.kernel.org, satishkh@...co.com, johndale@...co.com
Subject: Re: [PATCH net-next v2 3/4] enic: Report per queue statistics in
 ethtool

On Wed,  4 Sep 2024 18:08:59 -0700 Nelson Escobar wrote:
> Make 'ethtool -S <intf>' output show per rq/wq statistics.

> +static const struct enic_stat enic_per_wq_stats[] = {
> +	ENIC_PER_WQ_STAT(packets),
> +	ENIC_PER_WQ_STAT(stopped),

Stats for which structured APIs exist must not be added to ethtool -S
Please filter things which exist in qstat out of ethtool

please see:
https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
(it talks about rtnl_link_stats because only those existed at the time).