netdev - Re: [PATCH net v2] net: phy: dp83822: Fix NULL pointer dereference on DP83825 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240906143902.7fde7593@device-28.home>
Date: Fri, 6 Sep 2024 14:39:02 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Tomas Paukrt" <tomaspaukrt@...il.cz>
Cc: <netdev@...r.kernel.org>, "Andrew Lunn" <andrew@...n.ch>, "Heiner
 Kallweit" <hkallweit1@...il.com>, "Russell King" <linux@...linux.org.uk>,
 "David S. Miller" <davem@...emloft.net>, "Eric Dumazet"
 <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, "Paolo Abeni"
 <pabeni@...hat.com>, "Catalin Popescu"
 <catalin.popescu@...ca-geosystems.com>, "Simon Horman" <horms@...nel.org>
Subject: Re: [PATCH net v2] net: phy: dp83822: Fix NULL pointer dereference
 on DP83825 devices

On Fri, 06 Sep 2024 12:52:40 +0200 (CEST)
"Tomas Paukrt" <tomaspaukrt@...il.cz> wrote:

> The probe() function is only used for DP83822 and DP83826 PHY,
> leaving the private data pointer uninitialized for the DP83825 models
> which causes a NULL pointer dereference in the recently introduced/changed
> functions dp8382x_config_init() and dp83822_set_wol().
> 
> Add the dp8382x_probe() function, so all PHY models will have a valid
> private data pointer to fix this issue and also prevent similar issues
> in the future.
> 
> Fixes: 9ef9ecfa9e9f ("net: phy: dp8382x: keep WOL settings across suspends")
> Signed-off-by: Tomas Paukrt <tomaspaukrt@...il.cz>

That looks OK to me. Note that you must wait 24h between iterations,
to give everyone a chance to review.

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Thanks,

Maxime