netdev - Re: [PATCH -next v2 1/2] ptp: Check timespec64 before call settime64()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZtsMsouumhHTuEmB@hoboy.vegasvil.org>
Date: Fri, 6 Sep 2024 07:07:46 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: bryan.whitehead@...rochip.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, UNGLinuxDriver@...rochip.com,
	andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCH -next v2 1/2] ptp: Check timespec64 before call
 settime64()

On Fri, Sep 06, 2024 at 02:37:58PM +0800, Jinjie Ruan wrote:

> > See SYSCALL_DEFINE2(clock_settime, ...)
> > 
> >> +	if (!timespec64_valid(tp)) {
> >> +		pr_warn("ptp: tv_sec or tv_usec out of range\n");
> >> +		return -ERANGE;
> >> +	}
> > 
> > Shouldn't this be done at the higher layer, in clock_settime() ?
> 
> Maybe it is more reasonable?

I think so.  If you code that up, please include lkml and the time
keeping folks (Miroslav, John Stultz, tglx) on CC.

Thanks,
Richard