netdev - Re: [PATCH net-next] net: remove dev_pick_tx_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJToC3QymBvU=S_uyjwRMQkN1M6qtY6MX0DYPFpnd1fHA@mail.gmail.com>
Date: Fri, 6 Sep 2024 18:32:13 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] net: remove dev_pick_tx_cpu_id()

On Fri, Sep 6, 2024 at 6:11 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> dev_pick_tx_cpu_id() has been introduced with two users by
> commit a4ea8a3dacc3 ("net: Add generic ndo_select_queue functions").
> The use in AF_PACKET has been removed in 2019 by
> commit b71b5837f871 ("packet: rework packet_pick_tx_queue() to use common code selection")
> The other user was a Netlogic XLP driver, removed in 2021 by
> commit 47ac6f567c28 ("staging: Remove Netlogic XLP network driver").
>
> It's relatively unlikely that any modern driver will need an
> .ndo_select_queue implementation which picks purely based on CPU ID
> and skips XPS, delete dev_pick_tx_cpu_id()
>
> Found by code inspection.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>