lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <PH7PR12MB590332BF2B4CF7F7E3D0D8B9C09E2@PH7PR12MB5903.namprd12.prod.outlook.com>
Date: Fri, 6 Sep 2024 19:25:46 +0000
From: Yevgeny Kliteynik <kliteyn@...dia.com>
To: Simon Horman <horms@...nel.org>, Saeed Mahameed <saeed@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, Saeed
 Mahameed <saeedm@...dia.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Tariq Toukan <tariqt@...dia.com>, Gal Pressman
	<gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>, Itamar Gozlan
	<igozlan@...dia.com>
Subject: RE: [net-next V2 14/15] net/mlx5: HWS, added send engine and context
 handling

> From: Simon Horman <horms@...nel.org>
> Sent: Friday, September 6, 2024 21:21
> > +
> > +     err = hws_send_ring_alloc_cq(mdev, numa_node, queue, cqc_data, cq);
> > +     if (err) {
> > +             goto err_out;
> > +             return err;
> 
> Hi Saeed, Yevgeny, all,
> 
> A minor nit: the line above cannot be reached.
> 
> Flagged by Smatch.

Thanks Simon, fixing this in V3.

-- YK

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ