netdev - Re: [PATCH net-next v2 00/10] net: Convert using devm_clk_get_enabled()/devm_clk_get_optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33b03d5a-ec1e-4aa1-be17-3e67707ad6d2@huawei.com>
Date: Sat, 7 Sep 2024 11:03:35 +0800
From: Li Zetao <lizetao1@...wei.com>
To: <mchehab@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <wens@...e.org>,
	<jernej.skrabec@...il.com>, <samuel@...lland.org>, <heiko@...ech.de>,
	<yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, <hauke@...ke-m.de>,
	<alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>,
	<mcoquelin.stm32@...il.com>, <wellslutw@...il.com>,
	<radhey.shyam.pandey@....com>, <michal.simek@....com>, <hdegoede@...hat.com>,
	<ilpo.jarvinen@...ux.intel.com>, <ruanjinjie@...wei.com>,
	<hverkuil-cisco@...all.nl>, <u.kleine-koenig@...gutronix.de>,
	<jacky_chou@...eedtech.com>, <jacob.e.keller@...el.com>
CC: <linux-media@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-sunxi@...ts.linux.dev>,
	<linux-rockchip@...ts.infradead.org>,
	<linux-stm32@...md-mailman.stormreply.com>,
	<platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH net-next v2 00/10] net: Convert using
 devm_clk_get_enabled()/devm_clk_get_optional_enabled()

Sorry to bother you, I made a small mistake when I sent the patch. 
Please ignore the patchset.

在 2024/9/7 11:09, Li Zetao 写道:
> v1 -> v2:
>    1) Patch 5 optimizes the check and adds commit information for easier
>    inspection.
>    2) It is no longer necessary to use clk, so delete the clk member of
>    the spl2sw_common structure.
>    3) Remove patches 11 and 12, they should be sent to wireless-next
>    individually
> 
> v1:
> https://lore.kernel.org/all/20240831021334.1907921-1-lizetao1@huawei.com/
> 
> There are many examples[1][2] of clk resource leakage in LTS. The
> reason is that developers need to maintain the allocation and release
> of clk resources themselves, but this will increase the burden on
> developers. Using the API related to devm_clk_get_*_enable ensures
> that the life cycle of clk is consistent with that of the device,
> reducing the risk of unreleased resources like clk.
> 
> Several other developers are also working on converting to more
> secure interfaces, and this patch set is in principle the same as
> theirs.
> 
> [1]:
> https://lore.kernel.org/all/20240812160128.338041191@linuxfoundation.org/
> [2]:
> https://lore.kernel.org/all/20240812160135.992451065@linuxfoundation.org/
> 
> Li Zetao (10):
>    net: dsa: bcm_sf2: Convert using devm_clk_get_optional_enabled() in
>      bcm_sf2_sw_probe()
>    net: ethernet: Convert using devm_clk_get_enabled() in emac_probe()
>    net: ethernet: arc: Convert using devm_clk_get_enabled() in
>      emac_probe()
>    net: ethernet: ethoc: Convert using devm_clk_get_enabled() in
>      ethoc_probe()
>    net: ftgmac100: Convert using devm_clk_get_enabled() in
>      ftgmac100_setup_clk()
>    net: ethernet: hisilicon: Convert using devm_clk_get_enabled() in
>      hisi_femac_drv_probe()
>    net: lantiq_xrx200: Convert using devm_clk_get_enabled() in
>      xrx200_probe()
>    net: stmmac: dwmac-dwc-qos-eth: Convert using devm_clk_get_enabled()
>      in dwc_qos_probe()
>    net: ethernet: sunplus: Convert using devm_clk_get_enabled() in
>      spl2sw_probe()
>    net: xilinx: axienet: Convert using devm_clk_get_optional_enabled() in
>      axienet_probe()
> 
>   drivers/net/dsa/bcm_sf2.c                     | 28 ++----
>   drivers/net/ethernet/allwinner/sun4i-emac.c   | 13 +--
>   drivers/net/ethernet/arc/emac_rockchip.c      | 34 ++-----
>   drivers/net/ethernet/ethoc.c                  | 18 ++--
>   drivers/net/ethernet/faraday/ftgmac100.c      | 26 +----
>   drivers/net/ethernet/hisilicon/hisi_femac.c   | 17 +---
>   drivers/net/ethernet/lantiq_xrx200.c          | 17 +---
>   .../stmicro/stmmac/dwmac-dwc-qos-eth.c        | 98 ++++---------------
>   drivers/net/ethernet/sunplus/spl2sw_define.h  |  1 -
>   drivers/net/ethernet/sunplus/spl2sw_driver.c  | 25 ++---
>   .../net/ethernet/xilinx/xilinx_axienet_main.c | 15 +--
>   11 files changed, 62 insertions(+), 230 deletions(-)
>