netdev - Re: [PATCH net-next v2 2/2] selftests: txtimestamp: add SCM_TS_OPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoD9WQvJ_UfiYLZz6t=JOu_xPxEG_RKNBggzHnBUADLE6g@mail.gmail.com>
Date: Mon, 9 Sep 2024 07:36:55 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Willem de Bruijn <willemb@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] selftests: txtimestamp: add SCM_TS_OPT_ID test

On Mon, Sep 9, 2024 at 4:04 AM Vadim Fedorenko
<vadim.fedorenko@...ux.dev> wrote:
>
> On 02/09/2024 15:24, Jason Xing wrote:
> > On Mon, Sep 2, 2024 at 9:09 PM Vadim Fedorenko <vadfed@...a.com> wrote:
> >>
> >> Extend txtimestamp udp test to run with fixed tskey using
> >> SCM_TS_OPT_ID control message.
> >>
> >> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> >> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>
> >
> > Thanks for adding the combination test !
> >
> > Reviewed-by: Jason Xing <kerneljasonxing@...il.com>
>
> Apparently, I realised that combination tests had been coded before this
> change.
>
> run_test_all() {
>    setup
>    run_test_tcpudpraw    # setsockopt
>    run_test_tcpudpraw -C   # cmsg
>    run_test_tcpudpraw -n   # timestamp w/o data
>    echo "OK. All tests passed"
> }
>
> This function runs tests for TCP/UDP/RAW sockets (defined in
> run_test_tcpudpraw) 3 different times - with no extra options,
> with CMSG option and with "run_test_tcpudpraw":
>
> run_test_tcpudpraw() {
>    local -r args=$@
>
>    run_test_v4v6 ${args}   # tcp
>    run_test_v4v6 ${args} -u  # udp
>    run_test_v4v6 ${args} -r  # raw
>    run_test_v4v6 ${args} -R  # raw (IPPROTO_RAW)
>    run_test_v4v6 ${args} -P  # pf_packet
> }
>
> So if I add "-o <val>" for UDP and RAW sockets in run_test_tcpudpraw it
> will be run with CMSG option too.
>
> I'll remove the "run_test_v4v6 ${args} -u -o 42 -C" from the next
> version as it's already covered.

Oh, right. Thanks for finding this.