netdev - Re: [PATCH 0/7] net: Use IRQF_NO_AUTOEN flag in request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87seu8c2n7.fsf@kernel.org>
Date: Mon, 09 Sep 2024 17:39:24 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: <davem@...emloft.net>,  <edumazet@...gle.com>,  <kuba@...nel.org>,
  <pabeni@...hat.com>,  <claudiu.manoil@....com>,
  <vladimir.oltean@....com>,  <louis.peens@...igine.com>,
  <stefan@...enfreihafen.org>,  <alex.aring@...il.com>,
  <miquel.raynal@...tlin.com>,  <chunkeey@...glemail.com>,
  <briannorris@...omium.org>,  <francesco@...cini.it>,
  <set_pte_at@...look.com>,  <damien.lemoal@...nsource.wdc.com>,
  <mpe@...erman.id.au>,  <horms@...nel.org>,  <yinjun.zhang@...igine.com>,
  <fei.qin@...igine.com>,  <johannes.berg@...el.com>,
  <ryno.swart@...igine.com>,  <krzysztof.kozlowski@...aro.org>,
  <leitao@...ian.org>,  <liuxuenetmail@...il.com>,
  <netdev@...r.kernel.org>,  <linux-kernel@...r.kernel.org>,
  <oss-drivers@...igine.com>,  <linux-wpan@...r.kernel.org>,
  <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH 0/7] net: Use IRQF_NO_AUTOEN flag in request_irq()

Jinjie Ruan <ruanjinjie@...wei.com> writes:

> As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
> said, reqeust_irq() and then disable_irq() is unsafe.
>
> And the code below is subobtimal:
> 	 irq_set_status_flags(irq, IRQ_NOAUTOEN);
> 	 request_irq(dev, irq...);
>
> IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents
> the automatic enabling of the requested interrupt in the same safe way.
> With that the usage can be simplified and corrected.
>
> Only compile-tested.
>
> Jinjie Ruan (7):
>   net: apple: bmac: Use IRQF_NO_AUTOEN flag in request_irq()
>   net: enetc: Use IRQF_NO_AUTOEN flag in request_irq()
>   nfp: Use IRQF_NO_AUTOEN flag in request_irq()
>   net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq()
>   wifi: p54: Use IRQF_NO_AUTOEN flag in request_irq()
>   wifi: mwifiex: Use IRQF_NO_AUTOEN flag in request_irq()
>   wifi: wl1251: Use IRQF_NO_AUTOEN flag in request_irq()
>
>  drivers/net/ethernet/apple/bmac.c                   | 3 +--
>  drivers/net/ethernet/freescale/enetc/enetc.c        | 3 +--
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 ++---
>  drivers/net/ieee802154/mcr20a.c                     | 5 +----
>  drivers/net/wireless/intersil/p54/p54spi.c          | 4 +---
>  drivers/net/wireless/marvell/mwifiex/main.c         | 4 ++--
>  drivers/net/wireless/ti/wl1251/sdio.c               | 4 ++--
>  7 files changed, 10 insertions(+), 18 deletions(-)

Wireless patches go to wireless-next, please submit them in a separate
patchset.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches