netdev - Re: [PATCH net-next v2 08/10] net: netconsole: do not pass userdata up to the tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240910-certain-weasel-of-bliss-1cf769@devvm32600>
Date: Tue, 10 Sep 2024 02:44:41 -0700
From: Breno Leitao <leitao@...ian.org>
To: Simon Horman <horms@...nel.org>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, thepacketgeek@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, davej@...emonkey.org.uk,
	vlad.wing@...il.com, max@...sevol.com
Subject: Re: [PATCH net-next v2 08/10] net: netconsole: do not pass userdata
 up to the tail

On Mon, Sep 09, 2024 at 05:05:28PM +0100, Simon Horman wrote:
> On Mon, Sep 09, 2024 at 06:07:49AM -0700, Breno Leitao wrote:
> > Do not pass userdata to send_msg_fragmented, since we can get it later.
> > 
> > This will be more useful in the next patch, where send_msg_fragmented()
> > will be split even more, and userdata is only necessary in the last
> > function.
> > 
> > Suggested-by: Simon Horman <horms@...nel.org>
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> 
> ...
> 
> > @@ -1094,7 +1098,6 @@ static void append_release(char *buf)
> >  
> >  static void send_msg_fragmented(struct netconsole_target *nt,
> >  				const char *msg,
> > -				const char *userdata,
> >  				int msg_len,
> >  				int release_len)
> >  {
> > @@ -1103,8 +1106,10 @@ static void send_msg_fragmented(struct netconsole_target *nt,
> >  	int offset = 0, userdata_len = 0;
> >  	const char *header, *msgbody;
> >  
> > -	if (userdata)
> > -		userdata_len = nt->userdata_length;
> > +#ifdef CONFIG_NETCONSOLE_DYNAMIC
> > +	userdata = nt->userdata_complete;
> > +	userdata_len = nt->userdata_length;
> > +#endif
> 
> userdata does not appear to be declared in this scope :(
> 
> .../netconsole.c:1110:9: error: 'userdata' undeclared (first use in this function)
>  1110 |         userdata = nt->userdata_complete;

Oh, during my rebase, I moved the declaration to a patch forward, and I
didn't catch this because I was just compiling and testing with the
whole patchset applied.

Thanks for catching it. I will send an updated version.
--breno