netdev - Re: [PATCH 4/7] net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75bfcd83-4b71-4fee-a560-5ca112e6fbb0@datenfreihafen.org>
Date: Tue, 10 Sep 2024 12:49:28 +0200
From: Stefan Schmidt <stefan@...enfreihafen.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 claudiu.manoil@....com, vladimir.oltean@....com, louis.peens@...igine.com,
 alex.aring@...il.com, miquel.raynal@...tlin.com, chunkeey@...glemail.com,
 kvalo@...nel.org, briannorris@...omium.org, francesco@...cini.it,
 set_pte_at@...look.com, damien.lemoal@...nsource.wdc.com,
 mpe@...erman.id.au, horms@...nel.org, yinjun.zhang@...igine.com,
 fei.qin@...igine.com, johannes.berg@...el.com, ryno.swart@...igine.com,
 krzysztof.kozlowski@...aro.org, leitao@...ian.org, liuxuenetmail@...il.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 oss-drivers@...igine.com, linux-wpan@...r.kernel.org,
 linux-wireless@...r.kernel.org
Subject: Re: [PATCH 4/7] net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in
 request_irq()

Hello Jinjie Ruan.

On 9/9/24 3:30 PM, Jinjie Ruan wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable when request IRQ.
> 
> Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>   drivers/net/ieee802154/mcr20a.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index 433fb5839203..020d392a98b6 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -1302,16 +1302,13 @@ mcr20a_probe(struct spi_device *spi)
>   		irq_type = IRQF_TRIGGER_FALLING;
>   
>   	ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr,
> -			       irq_type, dev_name(&spi->dev), lp);
> +			       irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), lp);
>   	if (ret) {
>   		dev_err(&spi->dev, "could not request_irq for mcr20a\n");
>   		ret = -ENODEV;
>   		goto free_dev;
>   	}
>   
> -	/* disable_irq by default and wait for starting hardware */
> -	disable_irq(spi->irq);
> -
>   	ret = ieee802154_register_hw(hw);
>   	if (ret) {
>   		dev_crit(&spi->dev, "ieee802154_register_hw failed\n");


Dave, Eric, Jakub, if you are taking them into net/net-next directly 
here is my ack (and Miquel's review as well).

Acked-by: Stefan Schmidt <stefan@...enfreihafen.org>

regards
Stefan Schmidt