netdev - Re: [PATCH net v2] selftests: rtnetlink: add 'ethtool' as a dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240909170737.1dbaa027@kernel.org>
Date: Mon, 9 Sep 2024 17:07:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ales Nezbeda <anezbeda@...hat.com>
Cc: netdev@...r.kernel.org, sdf@...ichev.me, sd@...asysnail.net,
 davem@...emloft.net
Subject: Re: [PATCH net v2] selftests: rtnetlink: add 'ethtool' as a
 dependency

On Mon,  9 Sep 2024 10:34:10 +0200 Ales Nezbeda wrote:
> Fixes: 3b5222e2ac57 ("selftests: rtnetlink: add MACsec offload tests")

Don't think it qualifies as a fix, it's an improvement.

> +require_command()
> +{
> +	local cmd=$1; shift
> +
> +	if [[ ! -x "$(command -v "$cmd")" ]]; then
> +		echo "SKIP: $cmd not installed"
> +		exit $ksft_skip
> +	fi
> +}

You can use net/forwarding's lib.sh in net/, altnames.sh already 
uses it.
-- 
pw-bot: cr